Changes for page Macros

Summary

• Page properties (1 modified, 0 added, 0 removed)

Details

Page properties

Content

...	...	@@ -147,13 +147,12 @@
147	147	#set($result_add_xobj = $query_add_xobj.bindValue('space', $spaceAbsRef).bindValue('nameExclude', $nameExcludeRef).addFilter('unique').execute())
148	148	#foreach($item in $result_add_xobj)
149	149	#set($doc = $xwiki.getDocument("${space}.${item}.WebHome"))
150		- #set($rightXObj = $doc.getObject("assets.pagemaker.pagemakerClass"))
151		- if()
152	152	#set($rightXObj = $doc.getObject("assets.pagemaker.pagemakerClass", true))
153	153	#set($discard = $rightXObj.set('pmSpaceOrder', $foreach.count))
154	154	#set($discard = $doc.save())
155	155	#end
156	156	#end
	155	+
157	157	#set($spaceExcludeRef = $space.replaceAll('([%_!])', '!$1').concat(".${codespace}"))
158	158	#set($spaceLikeRef = $space.replaceAll('([%_!])', '!$1').concat('.%'))
159	159	#set($query = $services.query.xwql("from doc.object(assets.pagemaker.pagemakerClass) met where doc.space like :space and doc.space <> :spaceExclude and doc.name <> 'WebPreferences' order by met.pmSpaceOrder asc"))
...	...	@@ -169,28 +169,29 @@
169	169	#set($json = $O_elementData.select-json)
170	170	#foreach($key in $json.keySet())
171	171	#set($spaceDocTitle = $json.get($key))
172		- #set($spaceDoc = $xwiki.getDocument("${key}.WebHome")) ## Fetch doc or create one if it does not exist by this name.
173		- #set($spaceXObj = $spaceDoc.getObject("assets.pagemaker.pagemakerClass")) ## Get the needed object if it exists.
174		- #if($spaceXObj)
175		- #set($order_error = ($spaceXObj.getProperty('pmSpaceOrder').value != $foreach.count))
176		- #set($title_error = ($spaceDoc.getTitle() != $spaceDocTitle))
177		- #if($spaceDoc.isNew()) ## Doc did not exist so spaceDoc needs a title and a default locale.
178		- #set($discard = $spaceDoc.setTitle($spaceDocTitle)) ## Title.
179		- #set($discard = $spaceDoc.setDefaultLocale("en")) ## Locale.
180		- #set($discard = $spaceXObj.set("pmSpaceOrder", $foreach.count)) ## Set the property with the (correct) value.
181		- #set($discard = $spaceDoc.save())
182		- #else
183		- #if($title_error) ## Doc did exist but the title did not match with the JSON value.
184		- #set($discard = $spaceDoc.setTitle($spaceDocTitle))
185		- #end
186		- #if($order_error) ## Either the property does not exist or the value is incorrect.
	171	+ #if(!$isGuest)
	172	+ #set($spaceDoc = $xwiki.getDocument("${key}.WebHome")) ## Fetch doc or create one if it does not exist by this name.
	173	+ #set($spaceXObj = $spaceDoc.getObject("assets.pagemaker.pagemakerClass", true)) ## Get or create the needed object.
	174	+ #set($order_error = ($spaceXObj.getProperty('pmSpaceOrder').value != $foreach.count))
	175	+ #set($title_error = ($spaceDoc.getTitle() != $spaceDocTitle))
	176	+ #if($spaceDoc.isNew()) ## Doc did not exist so spaceDoc needs a title and a default locale.
	177	+ #set($discard = $spaceDoc.setTitle($spaceDocTitle)) ## Title.
	178	+ #set($discard = $spaceDoc.setDefaultLocale("en")) ## Locale.
187	187	#set($discard = $spaceXObj.set("pmSpaceOrder", $foreach.count)) ## Set the property with the (correct) value.
188		- #end
189		- #if($title_error || $order_error) ## Save only if changed
190	190	#set($discard = $spaceDoc.save())
	181	+ #else
	182	+ #if($title_error) ## Doc did exist but the title did not match with the JSON value.
	183	+ #set($discard = $spaceDoc.setTitle($spaceDocTitle))
	184	+ #end
	185	+ #if($order_error) ## Either the property does not exist or the value is incorrect.
	186	+ #set($discard = $spaceXObj.set("pmSpaceOrder", $foreach.count)) ## Set the property with the (correct) value.
	187	+ #end
	188	+ #if($title_error || $order_error) ## Save only if changed
	189	+ #set($discard = $spaceDoc.save())
	190	+ #end
191	191	#end
192	192	#end
193		- <option value="$key">$json.get($key)</option>
	193	+ <option value="$key">$spaceDocTitle</option>
194	194	#end
195	195	#end
196	196	</select>